-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TRACING-5422: Add an example OpenTelemetry Collector CR with filelog receiver that parses OpenShift cluster logs #95995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@andreasgerstmayr: This pull request references TRACING-5422 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Tue Jul 15 12:53:02 - Prow CI generated the docs preview: |
@andreasgerstmayr: This pull request references TRACING-5422 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
filelog: | ||
include: | ||
- /var/log/pods/*/*/*.log | ||
exclude: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreasgerstmayr I verified the docs PR, just one thing, should we add this to the exclude path.
exclude:
- /var/log/pods/*/otc-container/*.log
- "/var/log/pods/*/*/*.gz"
- "/var/log/pods/*/*/*.log.*"
- "/var/log/pods/*/*/*.tmp"
- "/var/log/pods/default_*/*/*.log"
- "/var/log/pods/kube-*_*/*/*.log"
- "/var/log/pods/kube_*/*/*.log"
- "/var/log/pods/openshift-*_*/*/*.log"
- "/var/log/pods/openshift_*/*/*.log"
The paths exclude infrastructure logs and only collects application logs. This is what the logging team is using in the vector config with a clusterlog forwarder created to forward application logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if the customer wanted to scrape infrastructure or application logs.
The ticket was about assistance setting up the SCC (https://issues.redhat.com/browse/TRACING-5422).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, we should anyways exclude these.
- /var/log/pods/*/otc-container/*.log
- "/var/log/pods/*/*/*.gz"
- "/var/log/pods/*/*/*.log.*"
- "/var/log/pods/*/*/*.tmp"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
Updated filelog test:
|
…receiver that parses OpenShift cluster logs Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
4e66213
to
80d5a4b
Compare
@andreasgerstmayr: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
all supported OCP versions
Issue:
https://issues.redhat.com/browse/TRACING-5422
Link to docs preview:
https://95995--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-collector/otel-collector-receivers.html#filelog-receiver_otel-collector-receivers
QE review:
Additional information:
cc @max-cx